Add harper 0.14.0 #6314
Add harper 0.14.0 #6314
Conversation
initial json for harper-ls
remove v from version
|
Your changes do not pass checks. harper
|
|
Couple questions, should version in the json include the prefix 'v'. For example v0.12.0 . |
removed regex and added 'v' before $version check in update url
|
/verify |
|
Your changes do not pass checks. Invalid manifests
|
removed extra comma
|
/verify |
|
All changes look good. Wait for review from human collaborators. harper
|
Updates homepage, download, checkver, and autoupdate urls
|
Is there anything we can do to get this merged sooner? |
I can ping a maintainer to see if it's good to go. Looking back at my PR (which i made rather hastily), should i make adjustments to the description (to clarify that its a language server) and/or install command (to differentiate between ls and cli)? If it were to be merged now it would be called harper (scoop install harper), and install harper-ls. I only ask because harper cli exists as well, and maybe someone requests that in the future. |
I think you can keep the name, and install both binaries. I believe this is what the Arch package does. |
|
@niheaven Could you review this PR when you get the chance? |
Closes #6313